soopervisor --skip-docker should use the configured repository when running with AWS Batch #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unning with AWS Batch Fixed ploomber#130 Tested in AWS Batch, earlier it was submitting task using invalid image. Now, it's able to re-use previously created docker image. ``` $aws ecr get-login-password --region us-west-2 | docker login --username AWS --password-stdin xxx.dkr.ecr.us-west-2.amazonaws.com/prod-repo && soopervisor export deploy --skip-tests --ignore-git --skip-docker ```
soopervisor --skip-docker should use the configured repository when r…
|
can you fix the CI @meprem? I think the problem is that we're using an old Python version, I'm guessing upgrading to 3.10 or higher will fix the issue |
|
@edublancas I will take a look... thank you. |
meprem
commented
Feb 17, 2025
There was a problem hiding this comment.
Tested it locally.
(soopervisor) premkumar@Prems-MacBook-Pro soopervisor % invoke test
...
tests/test_config_classes.py::test_schema[KubeflowConfig-initial5-schema5]
/Users/premkumar/Downloads/code/soopervisor/tests/test_config_classes.py:122: PydanticDeprecatedSince20: The `dict` method is deprecated; use `model_dump` instead. Deprecated in Pydantic V2.0 to be removed in V3.0. See Pydantic V2 Migration Guide at https://errors.pydantic.dev/2.10/migration/
assert class_(**initial).dict() == schema
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================================= 282 passed, 12 skipped, 2 xfailed, 200334 warnings in 186.25s (0:03:06) ==================================================================
Traceback (most recent call last):
File "/Users/premkumar/miniconda3/envs/soopervisor/lib/python3.9/multiprocessing/resource_tracker.py", line 201, in main
cache[rtype].remove(name)
KeyError: '/loky-26148-9pgu6vbm'
(soopervisor) premkumar@Prems-MacBook-Pro soopervisor %
I don't think we need the following change in the pipeline:
(soopervisor) premkumar@Prems-MacBook-Pro soopervisor % git diff
diff --git a/tests/test_commons_docker.py b/tests/test_commons_docker.py
index ee2484f..63cd0ff 100644
--- a/tests/test_commons_docker.py
+++ b/tests/test_commons_docker.py
@@ -223,7 +223,7 @@ def test_docker_build(EXPORTER, config, tmp_fast_pipeline, capfd, monkeypatch):
assert (
env_contents
== """\
-git: master
+git: main
git_hash: SOMEHASH
"""
)
@@ -238,17 +238,17 @@ git_hash: SOMEHASH
[
None,
None,
- {"git": "master", "git_hash": "SOMEHASH"},
+ {"git": "main", "git_hash": "SOMEHASH"},
],
[
"env.something.yaml",
{"some": {"nested": "value"}},
- {"git": "master", "git_hash": "SOMEHASH", "some": {"nested": "value"}},
+ {"git": "main", "git_hash": "SOMEHASH", "some": {"nested": "value"}},
],
[
None,
{"some": {"nested": "value"}},
- {"git": "master", "git_hash": "SOMEHASH", "some": {"nested": "value"}},
+ {"git": "main", "git_hash": "SOMEHASH", "some": {"nested": "value"}},
],
],
ids=[
(soopervisor) premkumar@Prems-MacBook-Pro soopervisor %
|
I was able to reproduce the issue on ubuntu, and after upgrading from 3.8 to 3.9, tests were successful. |
|
@edublancas can you please review and merge these changes? Thank you. |
edublancas
requested changes
Feb 22, 2025
|
I see the CI is failing, my guess is that the python version is still the culprit - perhaps try 3.11 or 3.12 |
Ahh... Let me try upgrading the version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Right now, when using --skip-docker, the Batch exporter tries to determine the name of the container for the Job definition based on the package the soopervisor.yml file is in, but ideally it'd reuse the configured repository within that file in the Job definition if it's already provided.
Issue ticket number and link
Closes #130 #130
Checklist before requesting a review
Tested in AWS Batch, earlier it was submitting task using invalid image. Now, it's able to re-use previously created docker image.